linux-kernel - Re: [PATCH] resource: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0bc7da5-feec-dbcd-6fdd-e0bea359572d@intel.com>
Date:   Tue, 19 Jan 2021 15:32:32 +0100
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Chengyang Fan <cy.fan@...wei.com>
Cc:     guohanjun@...wei.com, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] resource: Remove unneeded semicolon

On 1/18/2021 2:50 AM, Chengyang Fan wrote:
> Remove a superfluous semicolon after function definition.
>
> Signed-off-by: Chengyang Fan <cy.fan@...wei.com>
> ---
>   include/linux/ioport.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index fe48b7840665..803c10f6a6df 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -337,7 +337,7 @@ static inline void irqresource_disabled(struct resource *res, u32 irq)
>   #ifdef CONFIG_IO_STRICT_DEVMEM
>   void revoke_devmem(struct resource *res);
>   #else
> -static inline void revoke_devmem(struct resource *res) { };
> +static inline void revoke_devmem(struct resource *res) { }
>   #endif
>   
>   #endif /* __ASSEMBLY__ */

The patch is fine AFAICS, so

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

but I'm not sure why it has been sent to me.

It would be better to send it to Greg instead.

Thanks!