linux-kernel - Re: [RFC PATCH 00/37] block: introduce bio_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jan 2021 09:14:22 -0500
From:   Mike Snitzer <snitzer@...hat.com>
To:     Chaitanya Kulkarni <chaitanya.kulkarni@....com>
Cc:     linux-block@...r.kernel.org, linux-xfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        drbd-dev@...ts.linbit.com, linux-bcache@...r.kernel.org,
        linux-raid@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-btrfs@...r.kernel.org, linux-ext4@...r.kernel.org,
        cluster-devel@...hat.com, jfs-discussion@...ts.sourceforge.net,
        dm-devel@...hat.com, axboe@...nel.dk, philipp.reisner@...bit.com,
        lars.ellenberg@...bit.com, efremov@...ux.com, colyli@...e.de,
        kent.overstreet@...il.com, agk@...hat.com, song@...nel.org,
        hch@....de, sagi@...mberg.me, martin.petersen@...cle.com,
        viro@...iv.linux.org.uk, clm@...com, josef@...icpanda.com,
        dsterba@...e.com, tytso@....edu, adilger.kernel@...ger.ca,
        rpeterso@...hat.com, agruenba@...hat.com, darrick.wong@...cle.com,
        shaggy@...nel.org, damien.lemoal@....com, naohiro.aota@....com,
        jth@...nel.org, tj@...nel.org, osandov@...com, bvanassche@....org,
        gustavo@...eddedor.com, asml.silence@...il.com,
        jefflexu@...ux.alibaba.com
Subject: Re: [RFC PATCH 00/37] block: introduce bio_init_fields()

On Tue, Jan 19 2021 at 12:05am -0500,
Chaitanya Kulkarni <chaitanya.kulkarni@....com> wrote:

> Hi,
> 
> This is a *compile only RFC* which adds a generic helper to initialize
> the various fields of the bio that is repeated all the places in
> file-systems, block layer, and drivers.
> 
> The new helper allows callers to initialize various members such as
> bdev, sector, private, end io callback, io priority, and write hints.
> 
> The objective of this RFC is to only start a discussion, this it not 
> completely tested at all. Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â  Â 
> Following diff shows code level benefits of this helper :-
> Â 38 files changed, 124 insertions(+), 236 deletions(-)


Please no... this is just obfuscation.

Adding yet another field to set would create a cascade of churn
throughout kernel (and invariably many callers won't need the new field
initialized, so you keep passing 0 for more and more fields).

Nacked-by: Mike Snitzer <snitzer@...hat.com>