linux-kernel - Re: [PATCH] can: mcp251xfd: mcp251xfd_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc10d919-4087-e61d-28c4-ccffabe7d95a@pengutronix.de>
Date:   Tue, 19 Jan 2021 08:54:32 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     angkery <angkery@....com>, manivannan.sadhasivam@...aro.org,
        thomas.kopp@...rochip.com, wg@...ndegger.com, davem@...emloft.net,
        kuba@...nel.org
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Junlin Yang <yangjunlin@...ong.com>
Subject: Re: [PATCH] can: mcp251xfd: mcp251xfd_handle_ivmif(): fix wrong NULL
 pointer check

On 1/19/21 3:02 AM, angkery wrote:
> From: Junlin Yang <yangjunlin@...ong.com>
> 
> if alloc_can_err_skb() returns NULL, we should check skb instead of cf.

Have a look at the function, there is a check for cf several times before this.
But as cf is initialized as NULL this is should be no problem.

While in:

| ca4c6ebeeb50 can: mcp251xfd: mcp251xfd_handle_rxif_one():
|             fix wrong NULL pointer check

a real problem has been fixed.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)