lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jan 2021 16:41:48 +0800 From: Kai-Heng Feng <kai.heng.feng@...onical.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, AceLan Kao <acelan.kao@...onical.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Mika Westerberg <mika.westerberg@...ux.intel.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Len Brown <lenb@...nel.org>, "open list:ACPI" <linux-acpi@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias On Tue, Jan 19, 2021 at 4:27 PM Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote: > > On Tue, Jan 19, 2021 at 04:15:13PM +0800, Kai-Heng Feng wrote: > > Commit 8765c5ba1949 ("ACPI / scan: Rework modalias creation when > > "compatible" is present") may create two "MODALIAS=" in uevent file if > > conditions are met. > > > > This breaks systemd-udevd, which assumes each "key" in uevent file is > > unique. The internal implementation of systemd-udevd overwrites the > > first MODALIAS with the second one, so its kmod rule doesn't load driver > > for the first MODALIAS. > > > > Right now it doesn't seem to have any user relies on the second > > MODALIAS, so change it to OF_MODALIAS to workaround the issue. > > > > Reference: https://github.com/systemd/systemd/pull/18163 > > Fixes: 8765c5ba1949 ("ACPI / scan: Rework modalias creation when "compatible" is present") > > Cc: AceLan Kao <acelan.kao@...onical.com> > > Cc: "Rafael J. Wysocki" <rafael@...nel.org> > > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > > Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>, > > Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com> > > --- > > drivers/acpi/device_sysfs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c > > index 96869f1538b9..c92b671cb816 100644 > > --- a/drivers/acpi/device_sysfs.c > > +++ b/drivers/acpi/device_sysfs.c > > @@ -260,7 +260,7 @@ int __acpi_device_uevent_modalias(struct acpi_device *adev, > > if (!adev->data.of_compatible) > > return 0; > > > > - if (len > 0 && add_uevent_var(env, "MODALIAS=")) > > + if (len > 0 && add_uevent_var(env, "OF_MODALIAS=")) > > Who will use OF_MODALIAS and where have you documented it? After this lands in mainline, I'll modify the pull request for systemd to add a new rule for OF_MODALIAS. I'll modify the comment on the function to document the change. Kai-Heng > > thanks, > > greg k-h
Powered by blists - more mailing lists