linux-kernel - Re: [PATCH 0/4] add xhci hooks for USB offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YAaziw6VGKY4eNgY@kroah.com>
Date:   Tue, 19 Jan 2021 11:25:15 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Howard Yen <howardyen@...gle.com>
Cc:     robh+dt@...nel.org, mathias.nyman@...el.com,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] add xhci hooks for USB offload

On Tue, Jan 19, 2021 at 06:10:40PM +0800, Howard Yen wrote:
> To let the xhci driver support USB offload, add hooks for vendor to have
> customized behavior for the initialization, memory allocation, irq work, and 
> device context synchronization. Detail is in each patch commit message.
> 
> Howard Yen (4):
>   usb: host: add xhci hooks for USB offload
>   usb: host: export symbols for xhci hooks usage
>   usb: xhci-plat: add xhci_plat_priv_overwrite
>   dt-bindings: usb: usb-xhci: add USB offload support
> 
>  .../devicetree/bindings/usb/usb-xhci.txt      |  1 +
>  drivers/usb/host/xhci-hub.c                   |  5 +
>  drivers/usb/host/xhci-mem.c                   | 99 ++++++++++++++++---
>  drivers/usb/host/xhci-plat.c                  | 45 ++++++++-
>  drivers/usb/host/xhci-plat.h                  |  9 ++
>  drivers/usb/host/xhci-ring.c                  | 19 +++-
>  drivers/usb/host/xhci.c                       | 89 +++++++++++++++++
>  drivers/usb/host/xhci.h                       | 38 +++++++
>  8 files changed, 289 insertions(+), 16 deletions(-)

Thanks so much for posting this.

A bit of background for the lists.  I helped review previous versions of
this patchset from Howard as he worked to convert the hacks from a
previous vendor into something that would be semi-sane.  It would be
great if we can take the previously-submitted Samsung usb-audio hooks
(as published in their kernel sources for their last-year phones) and
get it into something mergable with this scheme as well, as this is the
"correct" way to do what they were wanting to do.

Although I know that is outside of the work you probably have time for,
maybe I will work on that over the next few weeks...

thanks,

greg k-h