linux-kernel - Re: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9228BCF5-EFDE-4A23-96DB-674554979D44@oracle.com>
Date:   Tue, 19 Jan 2021 09:16:25 -0600
From:   Himanshu Madhani <himanshu.madhani@...cle.com>
To:     Enzo Matsumiya <ematsumiya@...e.de>
Cc:     linux-scsi <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Arun Easi <aeasi@...vell.com>, Quinn Tran <qutran@...vell.com>
Subject: Re: [PATCH] scsi: qla2xxx: fix description for parameter
 ql2xenforce_iocb_limit



> On Jan 18, 2021, at 12:49 PM, Enzo Matsumiya <ematsumiya@...e.de> wrote:
> 
> Parameter ql2xenforce_iocb_limit is enabled by default.
> 
> Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
> Signed-off-by: Enzo Matsumiya <ematsumiya@...e.de>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index f80abe28f35a..0e0fe5b09496 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -42,7 +42,7 @@ MODULE_PARM_DESC(ql2xfulldump_on_mpifail,
> int ql2xenforce_iocb_limit = 1;
> module_param(ql2xenforce_iocb_limit, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(ql2xenforce_iocb_limit,
> -		 "Enforce IOCB throttling, to avoid FW congestion. (default: 0)");
> +		 "Enforce IOCB throttling, to avoid FW congestion. (default: 1)");
> 
> /*
>  * CT6 CTX allocation cache
> -- 
> 2.29.2
> 

Good Catch. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>

--
Himanshu Madhani	 Oracle Linux Engineering