linux-kernel - Re: [PATCH v3 05/21] x86/fpu/xstate: Add a new variable to indicate dynamic user states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210119155758.GF27634@zn.tnic>
Date:   Tue, 19 Jan 2021 16:57:58 +0100
From:   Borislav Petkov <bp@...e.de>
To:     "Bae, Chang Seok" <chang.seok.bae@...el.com>
Cc:     Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, x86-ml <x86@...nel.org>,
        "Brown, Len" <len.brown@...el.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Liu, Jing2" <jing2.liu@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 05/21] x86/fpu/xstate: Add a new variable to indicate
 dynamic user states

On Fri, Jan 15, 2021 at 07:47:38PM +0000, Bae, Chang Seok wrote:
> On Jan 15, 2021, at 05:39, Borislav Petkov <bp@...e.de> wrote:
> > On Wed, Dec 23, 2020 at 07:57:01AM -0800, Chang S. Bae wrote:
> >> The perf has a buffer that is allocated on demand. The states saved in the
> > 
> > What's "the perf"? I hope to find out when I countinue reading…
> 
> Maybe it was better to write ‘Linux perf (tools)’ [1] here. Sorry for the
> confusion.

Well, I'm also confused as to what does the perf buffer have to do with
AMX?

> >> -#define XFEATURE_MASK_DYNAMIC (XFEATURE_MASK_LBR)
> >> +#define XFEATURE_MASK_SUPERVISOR_DYNAMIC (XFEATURE_MASK_LBR)
> > 
> > Is XFEATURE_MASK_USER_DYNAMIC coming too?
> 
> Instead of the new define, I thought the new variable --
> xfeatures_mask_user_dynamic, as its value needs to be determined at boot
> time.

Why isn't that in your commit message?

All I see a patch doing a bunch of renames, some unrelated blurb in the
commit message and I have no clue what's going on here and why you're
doing this. Your commit messages should contain simple english sentences
and explain *why* the change is needed - not *what* you're doing. The
*what* I can see from the diff itself, for the *why* I need a crystal
ball which I can't buy in any store.

So how about explaining the *why*?

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg