lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jan 2021 16:50:43 +0100 From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org> To: Mark Brown <broonie@...nel.org> Cc: Lee Jones <lee.jones@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mayulong <mayulong1@...wei.com>, Rob Herring <robh+dt@...nel.org>, devel@...verdev.osuosl.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 15/18] mfd: hi6421-spmi-pmic: move driver from staging Em Tue, 19 Jan 2021 13:46:22 +0000 Mark Brown <broonie@...nel.org> escreveu: > On Tue, Jan 19, 2021 at 11:14:20AM +0100, Mauro Carvalho Chehab wrote: > > > +int hi6421_spmi_pmic_read(struct hi6421_spmi_pmic *pmic, int reg) > > +{ > > + struct spmi_device *pdev; > > + u8 read_value = 0; > > + u32 ret; > > + > > + pdev = to_spmi_device(pmic->dev); > > + if (!pdev) { > > + pr_err("%s: pdev get failed!\n", __func__); > > + return -ENODEV; > > + } > > + > > + ret = spmi_ext_register_readl(pdev, reg, &read_value, 1); > > + if (ret) { > > + pr_err("%s: spmi_ext_register_readl failed!\n", __func__); > > + return ret; > > + } > > + return read_value; > > +} > > +EXPORT_SYMBOL(hi6421_spmi_pmic_read); > > The I/O here looks a lot like regmap_spmi_ext. Did a test here converting it to use regmap. It worked. I'm sending a (hopefully) final patchset. Regards, Mauro
Powered by blists - more mailing lists