linux-kernel - Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ddd0f29e30684ce9fcd2dd19a104bd2@codeaurora.org>
Date:   Tue, 19 Jan 2021 12:02:56 -0800
From:   mkalikot@...eaurora.org
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Jeff Johnson <jjohnson@...eaurora.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Prasad Sodagudi <psodagud@...cinc.com>,
        Elliot Berman <eberman@...cinc.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists

On 2021-01-15 13:53, Masahiro Yamada wrote:
> On Sat, Jan 16, 2021 at 5:15 AM <jjohnson@...eaurora.org> wrote:
>> 
>> On 2021-01-14 17:12, Masahiro Yamada wrote:
>> > On Fri, Jan 15, 2021 at 6:50 AM Jeff Johnson <jjohnson@...eaurora.org>
>> > wrote:
>> >>
>> >> From: Mahesh Kumar Kalikot Veetil <mkalikot@...eaurora.org>
>> >>
>> >> Modules with a large number of compilation units may be
>> >> exceeding AR and LD command argument list. Handle this gracefully by
>> >> writing the long argument list in a file. The command line options
>> >> read from file are inserted in place of the original @file option.
>> >>
>> >> The usage is well documented at
>> >> https://www.gnu.org/software/make/manual/html_node/File-Function.html
>> >>
>> >> Signed-off-by: Mahesh Kumar Kalikot Veetil <mkalikot@...eaurora.org>
>> >> Signed-off-by: Jeff Johnson <jjohnson@...eaurora.org>
>> >> ---
>> >
>> >
>> >
>> >
>> > First, is this a real problem?
>> > If so, which module is exceeding the command line limit?
>> 
>> On 2021-01-14 17:12, Masahiro Yamada wrote:
>> > First, is this a real problem?
>> > If so, which module is exceeding the command line limit?
>> 
>> Mahesh & I appreciate all of the feedback.
>> 
>> The issue is seen in an Android environment with an out-of-tree
>> driver. The combination of long path names and a large number
>> of source files is leading to the issue.
>> 
>> Since Mahesh & I are not Kbuild gurus, is there an alternative
>> solution to this issue?
>> 
>> Jeff
> 
> 
> I see.
> 
> The support for out-of-tree modules
> is not nice in this regard, but fixing it
> would need many changes.
> 

Agree with that. I checked the same after your first comment on this 
thread.
It needs changes in multiple layers of makefiles.

> 
> The long-term solution might be to upstream your driver,
> but it might not be possible.
> 
> 
> 
> 
> 
> 
> One cheesy workaround might be to point the module path
> via a symbolic link.
> 
> 
> Let's say your module is located in a very deep
> directory,
> /home/foo/long/long/.../path/to/your/module
> 
> 
>  make M=/home/foo/long/long/.../path/to/your/module modules
> 
> would fail due to the too long command line.
> 
> 
> 
> 
> First, create a symbolic link as follows:
> 
>  ln -s /home/foo/long/long/.../path/to/your/module mod_dir
> 
> 
> Then, pass the symbolic link to M= option.
> 
>  make M=mod_dir modules

Thanks for the suggestion. Earlier, we have used a similar workaround
of using relative path instead of absolute to reduce the command line
length.


What's your input on the following approach where we link object
files in different stages to reduce the command line length.


./Makefile

  # foo.c is combined and final module.

  obj-m = fooa.o foob.o fooc.o

  # link already combined object files
  fooc-y := fooa.o foob.o

  # combine into different groups
  fooa-y := foo1.o foo2.o
  foob-y := foo3.o foo4.o

  ....


Note: We need to add MODULE_LICENSE in every group.


make -C ../linux-kbuild M=/local/mnt2/workspace/dev/foo modules

   CC [M]  /local/mnt2/workspace/dev/foo/foo1.o
   CC [M]  /local/mnt2/workspace/dev/foo/foo2.o
   LD [M]  /local/mnt2/workspace/dev/foo/fooa.o
   CC [M]  /local/mnt2/workspace/dev/foo/foo3.o
   CC [M]  /local/mnt2/workspace/dev/foo/foo4.o
   LD [M]  /local/mnt2/workspace/dev/foo/foob.o
   LD [M]  /local/mnt2/workspace/dev/foo/fooc.o
   MODPOST /local/mnt2/workspace/dev/foo/Module.symvers
   CC [M]  /local/mnt2/workspace/dev/foo/fooa.mod.o
   LD [M]  /local/mnt2/workspace/dev/foo/fooa.ko
   CC [M]  /local/mnt2/workspace/dev/foo/foob.mod.o
   LD [M]  /local/mnt2/workspace/dev/foo/foob.ko
   CC [M]  /local/mnt2/workspace/dev/foo/fooc.mod.o
   LD [M]  /local/mnt2/workspace/dev/foo/fooc.ko