linux-kernel - Re: [PATCH 0/2] introduce DUMP_PREFIX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210119151045.15c1fee3@gandalf.local.home>
Date:   Tue, 19 Jan 2021 15:10:45 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Timur Tabi <timur@...nel.org>
Cc:     Kees Cook <keescook@...omium.org>,
        Matthew Wilcox <willy@...radead.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        Petr Mladek <pmladek@...e.com>, roman.fietze@...na.com,
        John Ogness <john.ogness@...utronix.de>, linux-mm@...ck.org,
        Akinobu Mita <akinobu.mita@...il.com>
Subject: Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps

On Tue, 19 Jan 2021 13:55:29 -0600
Timur Tabi <timur@...nel.org> wrote:
> >   		case DUMP_PREFIX_ADDRESS:
> >   			printk("%s%s%p: %s\n",
> > -			       level, prefix_str, ptr + i, linebuf);
> > +			       level, prefix_str, addr + i, linebuf);  
> 
> Well, this is better than nothing, but not by much.  Again, as long as 
> %px exists for printk(), I just cannot understand any resistance to 
> allowing it in print_hex_dump().
> 
> Frankly, I think this patch and my patch should both be added.  During 
> debugging, it's very difficult if not impossible to work with hashed 
> addresses.  I use print_hex_dump() with an unhashed address all the 
> time, either by applying my patch to my own kernel or just replacing the 
> %p with %px.

I'm curious, what is the result if you replaced %p with %pS?

That way you get a kallsyms offset version of the output, which could still
be very useful depending on what you are dumping.

-- Steve