linux-kernel - Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf-ZmPuOjRYwNbURJXP3g_-m1LUDbsWtKHMvP49jseprw@mail.gmail.com>
Date:   Wed, 20 Jan 2021 19:09:46 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Al Cooper <alcooperx@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        devicetree <devicetree@...r.kernel.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        USB <linux-usb@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v2 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

On Wed, Jan 20, 2021 at 7:05 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Wed, Jan 20, 2021 at 06:47:52PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 19, 2021 at 8:16 PM Florian Fainelli <f.fainelli@...il.com> wrote:
> > > On 1/19/2021 7:21 AM, Andy Shevchenko wrote:
> > > > On Fri, Jan 15, 2021 at 11:19 PM Al Cooper <alcooperx@...il.com> wrote:

...

> > > Not sure this makes sense, given that the DMA hardware that was added to
> > > this UART block is only used by the UART block and no other pieces of HW
> > > in the system, nor will they ever be. Not sure it makes sense to pay the
> > > cost of an extra indirection and subsystem unless there are at least two
> > > consumers of that DMA hardware to warrant modeling it after a dmaengine
> > > driver. I also remember that Al researched before whether 8250_dma.c
> > > could work, and came to the conclusion that it would not, but I will let
> > > him comment on the specifics.
> >
> > I see. In any case I still believe that the driver can be shrinked by
> > a notable amount of lines.
>
> Patches always gladly accepted :)

Or a good review... :-)

-- 
With Best Regards,
Andy Shevchenko