linux-kernel - Re: [PATCH] watchdog/hpwdt: Assign boolean values to a bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210120190526.GA162927@roeck-us.net>
Date:   Wed, 20 Jan 2021 11:05:26 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
Cc:     jerry.hoemann@....com, wim@...ux-watchdog.org,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog/hpwdt: Assign boolean values to a bool variable

On Wed, Jan 20, 2021 at 03:48:10PM +0800, Jiapeng Zhong wrote:
> Fix the following coccicheck warnings:
> 
>  ./drivers/watchdog/hpwdt.c:345:2-12: WARNING: Assignment of
> 0/1 to bool variable.
> 
> ./drivers/watchdog/hpwdt.c:126:2-12: WARNING: Assignment of
> 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/hpwdt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index cbd1498..22ddba3 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -123,7 +123,7 @@ static int hpwdt_settimeout(struct watchdog_device *wdd, unsigned int val)
>  	if (val <= wdd->pretimeout) {
>  		dev_dbg(wdd->parent, "pretimeout < timeout. Setting to zero\n");
>  		wdd->pretimeout = 0;
> -		pretimeout = 0;
> +		pretimeout = false;
>  		if (watchdog_active(wdd))
>  			hpwdt_start(wdd);
>  	}
> @@ -336,13 +336,13 @@ static int hpwdt_init_one(struct pci_dev *dev,
>  	watchdog_init_timeout(&hpwdt_dev, soft_margin, NULL);
>  
>  	if (is_kdump_kernel()) {
> -		pretimeout = 0;
> +		pretimeout = false;
>  		kdumptimeout = 0;
>  	}
>  
>  	if (pretimeout && hpwdt_dev.timeout <= PRETIMEOUT_SEC) {
>  		dev_warn(&dev->dev, "timeout <= pretimeout. Setting pretimeout to zero\n");
> -		pretimeout = 0;
> +		pretimeout = false;
>  	}
>  	hpwdt_dev.pretimeout = pretimeout ? PRETIMEOUT_SEC : 0;
>  	kdumptimeout = min(kdumptimeout, HPWDT_MAX_TIMER);
> -- 
> 1.8.3.1
>