linux-kernel - RE: [PATCH v2 2/2] clocksource: Add Intel Keem Bay Timer Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Jan 2021 19:18:59 +0000
From:   "Ayyathurai, Vijayakannan" <vijayakannan.ayyathurai@...el.com>
To:     "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>
CC:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mgross@...ux.intel.com" <mgross@...ux.intel.com>,
        "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@...el.com>,
        "Raja Subramanian, Lakshmi Bai" 
        <lakshmi.bai.raja.subramanian@...el.com>,
        "Seow, Chen Yong" <chen.yong.seow@...el.com>
Subject: RE: [PATCH v2 2/2] clocksource: Add Intel Keem Bay Timer Support

Hi Andy,

> From: andriy.shevchenko@...ux.intel.com
> 
> > > > +	data.base = of_iomap(np, 2);
> > > > +	if (!data.base)
> > > > +		return -ENXIO;
> > > > +
> > > > +	ret = keembay_clocksource_init(np, &data);
> > > > +	if (ret)
> > > > +		goto exit;
> > > > +
> > > > +	ret = keembay_clockevent_init(np, &data);
> > >
> > > Is this missing ?
> > >
> >
> > Yes. Either case it goes to the exit path. So I thought of avoiding this error
> handling code.
> 
> The point is that in success you probably won't call keembay_timer_cleanup().
> 

Yes. You are right, if I use this error handling code.

> > > 	if (ret)
> > > 		goto exit;
> > >
> > > 	return 0;
> > >
> > > > +exit:
> > > > +	keembay_timer_cleanup(np, &data);
> > > > +
> > > > +	return ret;
> > > > +}
> 
Thanks,
Vijay