linux-kernel - RE: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSAPR01MB273719F67F6E438D85FF08CFC2A20@OSAPR01MB2737.jpnprd01.prod.outlook.com>
Date:   Wed, 20 Jan 2021 18:44:40 +0000
From:   Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Rob Herring <robh+dt@...nel.org>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
CC:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Ramesh Shanmugasundaram <rashanmu@...il.com>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das.jz@...renesas.com>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Rob Herring <robh@...nel.org>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Subject: RE: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif: Convert
 to json-schema

Hi Geert,


> From: Fabrizio Castro
> Sent: 20 January 2021 18:19
> Subject: RE: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif:
> Convert to json-schema
> 
> Hi Geert,
> 
> Thank you for your feedback.
> 
> > From: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Sent: 14 January 2021 13:03
> > Subject: Re: [PATCH v5 2/5] media: dt-bindings: media: renesas,drif:
> > Convert to json-schema
> >
> > Hi Fabrizio, Rob,
> >
> > On Wed, Oct 21, 2020 at 3:53 PM Fabrizio Castro
> > <fabrizio.castro.jz@...esas.com> wrote:
> > > Convert the Renesas DRIF bindings to DT schema and update
> > > MAINTAINERS accordingly.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > > Reviewed-by: Rob Herring <robh@...nel.org>
> >
> > Thanks for your patch!
> >
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> >
> > > +  clock-names:
> > > +    maxItems: 1
> > > +    items:
> > > +      - const: fck
> >
> > With latest dt-schema, "make dt_binding_check" complains:
> >
> >     Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > properties:clock-names:maxItems: False schema does not allow 1
> >     Documentation/devicetree/bindings/media/renesas,drif.yaml:
> > ignoring, error in schema: properties: clock-names: maxItems
> >
> > Using
> >
> >        clock-names:
> >          const: fck
> >
> > Fixes that.
> 
> Do you need me to send a new version or are you going to amend
> this on your end?

Sorry, I have just realised Laurent handled this one.


Thanks,
Fab

> 
> >
> > However, I'm wondering why I do not get a complaint about the similar
> > clock/clock-names in
> > Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml.
> > Because they're part of an else branch?
> 
> Interesting, renesas,lvds.yaml doesn't seem to trigger the problem
> from within the "then" branch either if I hack it, it only seems to
> trigger the problem when outside the if statement.
> 
> We probably need to remove "maxItems: 1" from renesas,lvds.yaml as
> well though, what do you think?
> 
> Thanks,
> Fab
> 
> >
> > Thanks!
> >
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> > m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker.
> > But
> > when I'm talking to journalists I just say "programmer" or something
> like
> > that.
> >                                 -- Linus Torvalds