linux-kernel - [PATCH] kbuild: warn a relative path used for M= in out-of-tree builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210120193100.3414664-1-masahiroy@kernel.org>
Date:   Thu, 21 Jan 2021 04:31:00 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     linux-kbuild@...r.kernel.org
Cc:     Will McVicker <willmcvicker@...gle.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] kbuild: warn a relative path used for M= in out-of-tree builds

Surprising to me, Kbuild can handle a relative M= path while having
in-kernel objects in a separate directory. In this case, the M= option
actually defines:

 - the path to external module sources relative to $(srctree)
 - the path to external module objects relative to $(objtree)

For example,

  make O=foo/bar M=baz

... will find the source files in baz, and create objects in foo/bar/baz.

Currently, it works like that because of the presence of VPATH and
--include-dir=$(abs_srctree), but this behavior is subtle and cannot
be guaranteed in the future. I do not know if it was even officially
supported ever.

I do not recommend this usage.

Reported-by: Will McVicker <willmcvicker@...gle.com>
Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
---

 Makefile | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Makefile b/Makefile
index b0e4767735dc..e42a27447eae 100644
--- a/Makefile
+++ b/Makefile
@@ -1699,6 +1699,13 @@ else # KBUILD_EXTMOD
 #                      Install the modules built in the module directory
 #                      Assumes install directory is already created
 
+ifdef building_out_of_srctree
+ifneq ($(filter-out /%, $(KBUILD_EXTMOD)),)
+$(warning The combination of out-of-tree build and relative M= path is not well supported.)
+$(warning Please do not complain about any trouble happening under this circumstance.)
+endif
+endif
+
 # We are always building only modules.
 KBUILD_BUILTIN :=
 KBUILD_MODULES := 1
-- 
2.27.0