linux-kernel - Re: [PATCH Broadcom/stblinux] soc: brcmstb: add stubs for getting platform IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb5980c6-87ba-ad26-c1fb-353735fd9181@gmail.com>
Date:   Wed, 20 Jan 2021 11:58:34 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <zajec5@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH Broadcom/stblinux] soc: brcmstb: add stubs for getting
 platform IDs



On 1/20/2021 11:48 AM, Florian Fainelli wrote:
> On Thu, 14 Jan 2021 11:53:18 +0100, Rafał Miłecki <zajec5@...il.com> wrote:
>> From: Rafał Miłecki <rafal@...ecki.pl>
>>
>> Some brcmstb drivers may be shared with other SoC families. E.g. the
>> same USB PHY block is shared by brcmstb and BCM4908.
>>
>> To avoid building brcmstb common code on non-brcmstb platforms we need
>> stubs for:
>> 1. brcmstb_get_family_id()
>> 2. brcmstb_get_product_id()
>> (to avoid "undefined reference to" errors).
>>
>> With this change PHY_BRCM_USB will not have to unconditionally select
>> SOC_BRCMSTB anymore.
>>
>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
>> ---
> 
> Applied to drivers/next, thanks!

Made some tweaks to the patch:

- subject is prefixed with: soc: bcm: brcmstb to match previous patches
- used IS_ENABLED() instead of #ifdef because this may have to be a
loadable module in the future (because of GKI)

Thanks!
-- 
Florian