linux-kernel - Re: [PATCH v2] mmc: sdhci-iproc: Add ACPI bindings for the rpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95a92ce1-f64a-1eea-c29a-2d0f97011fb0@gmail.com>
Date:   Tue, 19 Jan 2021 16:09:06 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jeremy Linton <jeremy.linton@....com>, linux-mmc@...r.kernel.org
Cc:     adrian.hunter@...el.com, ulf.hansson@...aro.org, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        f.fainelli@...il.com, stefan.wahren@...e.com,
        nsaenzjulienne@...e.de, ardb@...nel.org
Subject: Re: [PATCH v2] mmc: sdhci-iproc: Add ACPI bindings for the rpi



On 1/19/2021 4:04 PM, Jeremy Linton wrote:
> The RPi4 has an Arasan controller it carries over
> from the RPi3 and a newer eMMC2 controller.
> Because of a couple of quirks, it seems wiser to bind
> these controllers to the same driver that DT is using
> on this platform rather than the generic sdhci_acpi
> driver with PNP0D40.
> 
> So, BCM2847 describes the older Arasan and
> BRCME88C describes the newer eMMC2. The older
> Arasan is reusing an existing ACPI _HID used
> by other OSs booting these tables on the RPi.
> 
> With this change, Linux is capable of utilizing the
> SD card slot, and the wifi when booted with
> UEFI+ACPI on the rpi4.

This is uber nit picking, but can you try to be consistent in how you
capitalize words throughout your commit subject and use common writing
such as: RPi, Wi-Fi, OSes.

> 
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian