linux-kernel - RE: [RFC PATCH 0/2] Avoid booting stall caused by idmap_kpti_install_ng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jan 2021 04:51:41 +0000
From:   Justin He <Justin.He@....com>
To:     Catalin Marinas <Catalin.Marinas@....com>,
        Will Deacon <will@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Anshuman Khandual <Anshuman.Khandual@....com>,
        Suzuki Poulose <Suzuki.Poulose@....com>,
        Mark Rutland <Mark.Rutland@....com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Richard Henderson <richard.henderson@...aro.org>,
        Dave P Martin <Dave.Martin@....com>,
        Steven Price <Steven.Price@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Rapoport <rppt@...nel.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        Gavin Shan <gshan@...hat.com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Mark Brown <broonie@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Cristian Marussi <Cristian.Marussi@....com>
Subject: RE: [RFC PATCH 0/2] Avoid booting stall caused by
 idmap_kpti_install_ng_mappings 

Hi,
Kindly ping 😊

> -----Original Message-----
> From: Jia He <justin.he@....com>
> Sent: Wednesday, January 13, 2021 9:41 AM
> To: Catalin Marinas <Catalin.Marinas@....com>; Will Deacon
> <will@...nel.org>; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Cc: Anshuman Khandual <Anshuman.Khandual@....com>; Suzuki Poulose
> <Suzuki.Poulose@....com>; Justin He <Justin.He@....com>; Mark Rutland
> <Mark.Rutland@....com>; Gustavo A. R. Silva <gustavoars@...nel.org>;
> Richard Henderson <richard.henderson@...aro.org>; Dave P Martin
> <Dave.Martin@....com>; Steven Price <Steven.Price@....com>; Andrew Morton
> <akpm@...ux-foundation.org>; Mike Rapoport <rppt@...nel.org>; Ard
> Biesheuvel <ardb@...nel.org>; Gavin Shan <gshan@...hat.com>; Kefeng Wang
> <wangkefeng.wang@...wei.com>; Mark Brown <broonie@...nel.org>; Marc Zyngier
> <maz@...nel.org>; Cristian Marussi <Cristian.Marussi@....com>
> Subject: [RFC PATCH 0/2] Avoid booting stall caused by
> 
> There is a 10s stall in idmap_kpti_install_ng_mappings when kernel boots
> on a Ampere EMAG server.
> 
> Commit f992b4dfd58b ("arm64: kpti: Add ->enable callback to remap
> swapper using nG mappings") updates the nG bit runtime if kpti is
> required.
> 
> But things get worse if rodata=full in map_mem(). NO_BLOCK_MAPPINGS |
> NO_CONT_MAPPINGS is required when creating pagetable mapping. Hence all
> ptes are fully mapped in this case. On a Ampere EMAG server with 256G
> memory(pagesize=4k), it causes the 10s stall.
> 
> After moving init_cpu_features() ahead of early_fixmap_init(), we can use
> cpu_have_const_cap earlier than before. Hence we can avoid this stall
> by updating arm64_use_ng_mappings.
> 
> After this patch series, it reduces the kernel boot time from 14.7s to
> 4.1s:
> Before:
> [   14.757569] Freeing initrd memory: 60752K
> After:
> [    4.138819] Freeing initrd memory: 60752K
> 
> Set it as RFC because I want to resolve any other points which I have
> misconerned.
> 
> Jia He (2):
>   arm64/cpuinfo: Move init_cpu_features() ahead of early_fixmap_init()
>   arm64: kpti: Update arm64_use_ng_mappings before pagetable mapping
> 
>  arch/arm64/include/asm/cpu.h |  1 +
>  arch/arm64/kernel/cpuinfo.c  | 13 ++++++++++---
>  arch/arm64/kernel/setup.c    | 18 +++++++++++++-----
>  arch/arm64/kernel/smp.c      |  3 +--
>  4 files changed, 25 insertions(+), 10 deletions(-)
> 
> --
> 2.17.1