linux-kernel - Re: [PATCH V2] RDMA: usnic: Fix misuse of sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210120003219.GA968146@nvidia.com>
Date:   Tue, 19 Jan 2021 20:32:19 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Joe Perches <joe@...ches.com>
CC:     James Bottomley <James.Bottomley@...senPartnership.com>,
        "Christian Benvenuti" <benve@...co.com>,
        Nelson Escobar <neescoba@...co.com>,
        "Doug Ledford" <dledford@...hat.com>, <linux-rdma@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH V2] RDMA: usnic: Fix misuse of sysfs_emit_at

On Fri, Jan 15, 2021 at 04:36:50PM -0800, Joe Perches wrote:
> In commit e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show
> uses to sysfs_emit") I mistakenly used len = sysfs_emit_at to overwrite
> the last trailing space of potentially multiple entry output.
> 
> Instead use a more common style by removing the trailing space from the
> output formats and adding a prefixing space to the contination formats and
> converting the final terminating output newline from the defective
> 	len = sysfs_emit_at(buf, len, "\n");
> to the now appropriate and typical
> 	len += sysfs_emit_at(buf, len, "\n");
> 
> Fixes: e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show uses to sysfs_emit")
> 
> Reported-by: James Bottomley <James.Bottomley@...senPartnership.com>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Applied to for-rc, thanks

Jason