linux-kernel - Re: [PATCH] i2c: sprd:: depend on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADBw62pML49WTTmv7GSzMhJAsAJnujnReH70Kb1nCj2bt1voDA@mail.gmail.com>
Date:   Wed, 20 Jan 2021 14:19:33 +0800
From:   Baolin Wang <baolin.wang7@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests

Hi,

On Sun, Jan 17, 2021 at 7:43 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> The I2C_SPRD uses Common Clock Framework thus it cannot be built on
> platforms without it (e.g. compile test on MIPS with LANTIQ):
>
>     /usr/bin/mips-linux-gnu-ld: drivers/i2c/busses/i2c-sprd.o: in function `sprd_i2c_probe':
>     i2c-sprd.c:(.text.sprd_i2c_probe+0x254): undefined reference to `clk_set_parent'
>
> Fixes: 4a2d5f663dab ("i2c: Enable compile testing for more drivers")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang7@...il.com>

> ---
>  drivers/i2c/busses/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index d4d60ad0eda0..ab1f39ac39f4 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -1013,6 +1013,7 @@ config I2C_SIRF
>  config I2C_SPRD
>         tristate "Spreadtrum I2C interface"
>         depends on I2C=y && (ARCH_SPRD || COMPILE_TEST)
> +       depends on COMMON_CLK
>         help
>           If you say yes to this option, support will be included for the
>           Spreadtrum I2C interface.
> --
> 2.25.1
>


-- 
Baolin Wang