linux-kernel - Re: [PATCH] x86/fpu/xstate: calculate the number by sizeof and offsetof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26c1f5be-7232-3e2b-dcbb-367ff0bbdbb8@intel.com>
Date:   Tue, 19 Jan 2021 22:49:18 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Yejune Deng <yejune.deng@...il.com>, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, x86@...nel.org, hpa@...or.com,
        dave.hansen@...ux.intel.com, yu-cheng.yu@...el.com,
        tony.luck@...el.com, fenghua.yu@...el.com,
        kan.liang@...ux.intel.com, viro@...iv.linux.org.uk
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/fpu/xstate: calculate the number by sizeof and
 offsetof

On 1/19/21 10:44 PM, Yejune Deng wrote:
> In fpstate_sanitize_xstate(), use memset and offsetof instead of '= 0',
> and use sizeof instead of a constant.

What's the benefit to doing this?  Saving 4 lines of code?

Your suggestions are not obviously wrong at a glance, but they're also
not obviously right.