linux-kernel - Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210120090108.bbdee781a237cb931a572323@bidouilliste.com>
Date:   Wed, 20 Jan 2021 09:01:08 +0100
From:   Emmanuel Vadot <manu@...ouilliste.com>
To:     Drew Fustini <drew@...gleboard.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins

On Tue, 19 Jan 2021 21:03:44 -0800
Drew Fustini <drew@...gleboard.org> wrote:

> Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
> 
> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
> Reported-by: Emmanuel Vadot <manu@...ouilliste.com>
> Link: https://lore.kernel.org/linux-gpio/20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com/
> Cc: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Drew Fustini <drew@...gleboard.org>
> ---
>  Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> index f903eb4471f8..bb9999119314 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> @@ -8,7 +8,7 @@ Required properties:
>  - reg : offset and length of the register set for the mux registers
>  
>  - #pinctrl-cells : number of cells in addition to the index, set to 1
> -  for pinctrl-single,pins and 2 for pinctrl-single,bits
> +  or 2 for pinctrl-single,pins and set to 2 for pinctrl-single,bits
>  
>  - pinctrl-single,register-width : pinmux register access width in bits
>  
> -- 
> 2.25.1
> 

 Reviewed-by: Emmanuel Vadot <manu@...eBSD.org>

 Thanks, now the docs make more sense :)

-- 
Emmanuel Vadot <manu@...ouilliste.com> <manu@...eBSD.org>