linux-kernel - Re: [PATCH] block: Fix an error handling in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210120100544.GC3694085@infradead.org>
Date:   Wed, 20 Jan 2021 10:05:44 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Jens Axboe <axboe@...nel.dk>,
        Jan Kara <jack@...e.cz>, Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <johannes.thumshirn@....com>,
        Ming Lei <ming.lei@...hat.com>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: Fix an error handling in add_partition

On Sun, Jan 17, 2021 at 04:50:17PM +0800, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>