linux-kernel - Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210120045736-mutt-send-email-mst@kernel.org>
Date:   Wed, 20 Jan 2021 04:57:46 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>,
        jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, Tian Tao <tiantao6@...ilicon.com>
Subject: Re: [PATCH] virtio-mem: Assign boolean values to a bool variable

On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
> On 20.01.21 08:50, Jiapeng Zhong wrote:
> > Fix the following coccicheck warnings:
> > 
> > ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
> > of 0/1 to bool variable.
> > 
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
> > ---
> >  drivers/virtio/virtio_mem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> > index 9fc9ec4..85a272c 100644
> > --- a/drivers/virtio/virtio_mem.c
> > +++ b/drivers/virtio/virtio_mem.c
> > @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> >  	 * actually in use (e.g., trying to reload the driver).
> >  	 */
> >  	if (vm->plugged_size) {
> > -		vm->unplug_all_required = 1;
> > +		vm->unplug_all_required = true;
> >  		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
> >  	}
> >  
> > 
> 
> Hi,
> 
> we already had a fix on the list for quite a while:
> 
> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com

Can't find that one.

> However, looks like Michael queued your patch on the vhost tree instead.
> 
> -- 
> Thanks,
> 
> David / dhildenb