linux-kernel - Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210120103648.GI11878@paasikivi.fi.intel.com>
Date:   Wed, 20 Jan 2021 12:36:48 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Biju Das <biju.das.jz@...renesas.com>,
        Prabhakar <prabhakar.csengg@...il.com>
Subject: Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor

On Wed, Jan 20, 2021 at 10:17:14AM +0000, Kieran Bingham wrote:
> Hi Lad,
> 
> On 20/01/2021 09:01, Lad Prabhakar wrote:
> > Fix OV772x build breakage by selecting V4L2_FWNODE config:
> > 
> > ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
> > ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> > ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
> > ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> > 
> > Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> 
> I see this driver uses subdev API too.
> 
> Should the driver also select VIDEO_V4L2_SUBDEV_API?

Yes, it should. Another patch? This one fixes a compilation problem.

> 
> Or is that covered sufficiently already on any platforms that would use
> the driver?
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> 
> > ---
> >  drivers/media/i2c/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > index eddb10220953..bb1b5a340431 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -1013,6 +1013,7 @@ config VIDEO_OV772X
> >  	tristate "OmniVision OV772x sensor support"
> >  	depends on I2C && VIDEO_V4L2
> >  	select REGMAP_SCCB
> > +	select V4L2_FWNODE
> >  	help
> >  	  This is a Video4Linux2 sensor driver for the OmniVision
> >  	  OV772x camera.
> > 
> 

-- 
Sakari Ailus