linux-kernel - Re: [PATCH 15/20] clk: ti: dpll: Fix misnaming of '_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cdddb5c-dcbd-3d69-a3d0-3e9a843e667f@kernel.org>
Date:   Wed, 20 Jan 2021 13:27:50 +0200
From:   Tero Kristo <kristo@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-omap@...r.kernel.org,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH 15/20] clk: ti: dpll: Fix misnaming of '_register_dpll()'s
 'user' parameter

On 20/01/2021 11:30, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/clk/ti/dpll.c:163: warning: Function parameter or member 'user' not described in '_register_dpll'
>   drivers/clk/ti/dpll.c:163: warning: Excess function parameter 'hw' description in '_register_dpll'
> 
> Cc: Tero Kristo <kristo@...nel.org>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: linux-omap@...r.kernel.org
> Cc: linux-clk@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Tero Kristo <kristo@...nel.org>

> ---
>   drivers/clk/ti/dpll.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/ti/dpll.c b/drivers/clk/ti/dpll.c
> index 247510e306e2a..d6f1ac5b53e14 100644
> --- a/drivers/clk/ti/dpll.c
> +++ b/drivers/clk/ti/dpll.c
> @@ -151,7 +151,7 @@ static const struct clk_ops dpll_x2_ck_ops = {
>   
>   /**
>    * _register_dpll - low level registration of a DPLL clock
> - * @hw: hardware clock definition for the clock
> + * @user: pointer to the hardware clock definition for the clock
>    * @node: device node for the clock
>    *
>    * Finalizes DPLL registration process. In case a failure (clk-ref or
>