lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Jan 2021 14:11:13 +0100 From: Peter Zijlstra <peterz@...radead.org> To: vincent.donnefort@....com Cc: tglx@...utronix.de, linux-kernel@...r.kernel.org, valentin.schneider@....com Subject: Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range() On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@....com wrote: > @@ -157,26 +162,24 @@ static int cpuhp_invoke_callback(unsigned int cpu, enum cpuhp_state state, > > if (st->fail == state) { > st->fail = CPUHP_INVALID; > - > - if (!(bringup ? step->startup.single : step->teardown.single)) > - return 0; > - > return -EAGAIN; > } > > + if (cpuhp_step_empty(bringup, step)) { > + WARN_ON_ONCE(1); > + return 0; > + } This changes the behaviour of fail.. might be best to refactor without changing behaviour. Lemme continue reading.
Powered by blists - more mailing lists