linux-kernel - Re: [PATCH] mm: Optimizing error condition detection in do_mprotect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YAg+QHhczqtTZt4Z@kernel.org>
Date:   Wed, 20 Jan 2021 16:29:20 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>, haitao.huang@...el.com,
        Kai Huang <kai.huang@...el.com>, x86@...nel.org,
        linux-sgx@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
        Jia Zhang <zhang.jia@...ux.alibaba.com>
Subject: Re: [PATCH] mm: Optimizing error condition detection in
 do_mprotect_pkey()



On Mon, Jan 18, 2021 at 09:33:10PM +0800, Tianjia Zhang wrote:
> Obviously, the error variable detection of the if statement is
> for the mprotect callback function, so it is also put into the
> scope of calling callbck.
> 
> Reported-by: Jia Zhang <zhang.jia@...ux.alibaba.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>

No fixes tag, no description what this commit does. Nothing
makes sense to me.

/Jarkko

> ---
>  mm/mprotect.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index ab709023e9aa..94188df1ee55 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -617,10 +617,11 @@ static int do_mprotect_pkey(unsigned long start, size_t len,
>  		if (tmp > end)
>  			tmp = end;
>  
> -		if (vma->vm_ops && vma->vm_ops->mprotect)
> +		if (vma->vm_ops && vma->vm_ops->mprotect) {
>  			error = vma->vm_ops->mprotect(vma, nstart, tmp, newflags);
> -		if (error)
> -			goto out;
> +			if (error)
> +				goto out;
> +		}
>  
>  		error = mprotect_fixup(vma, &prev, nstart, tmp, newflags);
>  		if (error)
> -- 
> 2.19.1.3.ge56e4f7
> 
>