linux-kernel - Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202101202242.tVSnpX8b-lkp@intel.com>
Date:   Wed, 20 Jan 2021 23:04:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Pawel Dembicki <paweldembicki@...il.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Linus Wallej <linus.walleij@...aro.org>,
        Pawel Dembicki <paweldembicki@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

Hi Pawel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on net-next/master ipvs/master linus/master v5.11-rc4 next-20210120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Pawel-Dembicki/dsa-vsc73xx-add-support-for-vlan-filtering/20210120-161228
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 8e4052c32d6b4b39c1e13c652c7e33748d447409
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1b3778a3f0b1d668f4fa289c82997ebbd2145178
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pawel-Dembicki/dsa-vsc73xx-add-support-for-vlan-filtering/20210120-161228
        git checkout 1b3778a3f0b1d668f4fa289c82997ebbd2145178
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_set_vlan_unaware':
>> drivers/net/dsa/vitesse-vsc73xx-core.c:686:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709535231' to '4294950911' [-Woverflow]
     686 |        ~VSC73XX_MAC_CFG_VLAN_AWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:689:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow]
     689 |        ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:698:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow]
     698 |        ~VSC73XX_CAT_DROP_TAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:701:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551611' to '4294967291' [-Woverflow]
     701 |        ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_set_vlan_aware':
   drivers/net/dsa/vitesse-vsc73xx-core.c:716:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow]
     716 |        ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   drivers/net/dsa/vitesse-vsc73xx-core.c:719:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551359' to '4294967039' [-Woverflow]
     719 |        ~VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:722:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551487' to '4294967167' [-Woverflow]
     722 |        ~VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:725:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow]
     725 |        ~VSC73XX_CAT_DROP_TAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c:734:8: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551607' to '4294967287' [-Woverflow]
     734 |        ~VSC73XX_TXUPDCFG_TX_UNTAGGED_VID_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_vlan_add':
   drivers/net/dsa/vitesse-vsc73xx-core.c:811:9: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551611' to '4294967291' [-Woverflow]
     811 |         ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   drivers/net/dsa/vitesse-vsc73xx-core.c: In function 'vsc73xx_port_vlan_del':
   drivers/net/dsa/vitesse-vsc73xx-core.c:848:9: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551607' to '4294967287' [-Woverflow]
     848 |         ~VSC73XX_TXUPDCFG_TX_UNTAGGED_VID_ENA);


vim +686 drivers/net/dsa/vitesse-vsc73xx-core.c

   678	
   679	static int vsc73xx_port_set_vlan_unaware(struct dsa_switch *ds, int port)
   680	{
   681		struct vsc73xx *vsc = ds->priv;
   682		int ret;
   683	
   684		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_MAC_CFG,
   685				    VSC73XX_MAC_CFG_VLAN_AWR,
 > 686				    ~VSC73XX_MAC_CFG_VLAN_AWR);
   687		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_MAC_CFG,
   688				    VSC73XX_MAC_CFG_VLAN_DBLAWR,
   689				    ~VSC73XX_MAC_CFG_VLAN_DBLAWR);
   690		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_VLAN_MISC,
   691				    VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA,
   692				    VSC73XX_CAT_VLAN_MISC_VLAN_TCI_IGNORE_ENA);
   693		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_VLAN_MISC,
   694				    VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA,
   695				    VSC73XX_CAT_VLAN_MISC_VLAN_KEEP_TAG_ENA);
   696		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_DROP,
   697				    VSC73XX_CAT_DROP_TAGGED_ENA,
   698				    ~VSC73XX_CAT_DROP_TAGGED_ENA);
   699		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_MAC, port, VSC73XX_CAT_DROP,
   700				    VSC73XX_CAT_DROP_UNTAGGED_ENA,
   701				    ~VSC73XX_CAT_DROP_UNTAGGED_ENA);
   702	
   703		ret = vsc73xx_port_update_vlan_table(ds, port, 0, 4095, 0);
   704		return ret;
   705	}
   706	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (72481 bytes)