linux-kernel - Re: [PATCH v4 1/4] mm: rename memmap_init() and memmap_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202101202302.EE9LLAFu-lkp@intel.com>
Date:   Wed, 20 Jan 2021 23:47:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     Baoquan He <bhe@...hat.com>, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, rppt@...nel.org, david@...hat.com,
        bhe@...hat.com
Subject: Re: [PATCH v4 1/4] mm: rename memmap_init() and memmap_init_zone()

Hi Baoquan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.11-rc4 next-20210120]
[cannot apply to mmotm/master hnaz-linux-mm/master ia64/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Baoquan-He/mm-clean-up-names-and-parameters-of-memmap_init_xxxx-functions/20210120-135239
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1e2a199f6ccdc15cf111d68d212e2fd4ce65682e
config: mips-randconfig-r036-20210120 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1bbb0b35dd2fae4a7a38098e63899677c2e53108
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Baoquan-He/mm-clean-up-names-and-parameters-of-memmap_init_xxxx-functions/20210120-135239
        git checkout 1bbb0b35dd2fae4a7a38098e63899677c2e53108
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   mm/page_alloc.c:3597:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
    3597 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
         |               ^~~~~~~~~~~~~~~~~~~~~~
>> mm/page_alloc.c:6258:23: warning: no previous prototype for 'memmap_init_zone' [-Wmissing-prototypes]
    6258 | void __meminit __weak memmap_init_zone(unsigned long size, int nid,
         |                       ^~~~~~~~~~~~~~~~


vim +/memmap_init_zone +6258 mm/page_alloc.c

  6257	
> 6258	void __meminit __weak memmap_init_zone(unsigned long size, int nid,
  6259					  unsigned long zone,
  6260					  unsigned long range_start_pfn)
  6261	{
  6262		unsigned long start_pfn, end_pfn;
  6263		unsigned long range_end_pfn = range_start_pfn + size;
  6264		int i;
  6265	
  6266		for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) {
  6267			start_pfn = clamp(start_pfn, range_start_pfn, range_end_pfn);
  6268			end_pfn = clamp(end_pfn, range_start_pfn, range_end_pfn);
  6269	
  6270			if (end_pfn > start_pfn) {
  6271				size = end_pfn - start_pfn;
  6272				memmap_init_range(size, nid, zone, start_pfn, range_end_pfn,
  6273						 MEMINIT_EARLY, NULL, MIGRATE_MOVABLE);
  6274			}
  6275		}
  6276	}
  6277	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30930 bytes)