linux-kernel - Re: [PATCH v5 1/2] mmc: Support kmsg dumper based on pstore/blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 21 Jan 2021 00:11:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bhaskara Budiredla <bbudiredla@...vell.com>,
        ulf.hansson@...aro.org, keescook@...omium.org, ccross@...roid.com,
        tony.luck@...el.com, sgoutham@...vell.com
Cc:     kbuild-all@...ts.01.org, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Bhaskara Budiredla <bbudiredla@...vell.com>
Subject: Re: [PATCH v5 1/2] mmc: Support kmsg dumper based on pstore/blk

Hi Bhaskara,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.11-rc4 next-20210120]
[cannot apply to kees/for-next/pstore]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bhaskara-Budiredla/mmc-support-crash-logging-to-MMC-block-devices/20210120-214535
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 45dfb8a5659ad286c28fa59008271dbc4e5e3f2d
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/69795d684b516b397dbfd2aec66d5e22645c03d9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bhaskara-Budiredla/mmc-support-crash-logging-to-MMC-block-devices/20210120-214535
        git checkout 69795d684b516b397dbfd2aec66d5e22645c03d9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/mmc/core/block.c: In function 'mmc_blk_get_part':
>> drivers/mmc/core/block.c:2883:34: error: 'struct block_device' has no member named 'nr_sects'
    2883 |  *size = part_tbl->part[part_num]->nr_sects << SECTOR_SHIFT;
         |                                  ^~
>> drivers/mmc/core/block.c:2884:35: error: 'struct block_device' has no member named 'start_sect'; did you mean 'bd_start_sect'?
    2884 |  return part_tbl->part[part_num]->start_sect;
         |                                   ^~~~~~~~~~
         |                                   bd_start_sect
   drivers/mmc/core/block.c:2885:1: error: control reaches end of non-void function [-Werror=return-type]
    2885 | }
         | ^
   cc1: some warnings being treated as errors
--
>> drivers/mmc/core/mmcpstore.c:31:25: error: field 'info' has incomplete type
      31 |  struct pstore_blk_info info;
         |                         ^~~~
   drivers/mmc/core/mmcpstore.c: In function 'mmcpstore_card_set':
>> drivers/mmc/core/mmcpstore.c:152:22: error: 'struct block_device' has no member named 'bd_part'; did you mean 'bd_partno'?
     152 |  cxt->partno = bdev->bd_part->partno;
         |                      ^~~~~~~
         |                      bd_partno
>> drivers/mmc/core/mmcpstore.c:192:6: error: dereferencing pointer to incomplete type 'struct pstore_blk_info'
     192 |  info->major = MMC_BLOCK_MAJOR;
         |      ^~
>> drivers/mmc/core/mmcpstore.c:195:8: error: implicit declaration of function 'register_pstore_blk'; did you mean 'register_pstore_zone'? [-Werror=implicit-function-declaration]
     195 |  ret = register_pstore_blk(info);
         |        ^~~~~~~~~~~~~~~~~~~
         |        register_pstore_zone
   drivers/mmc/core/mmcpstore.c: In function 'unregister_mmcpstore':
>> drivers/mmc/core/mmcpstore.c:221:2: error: implicit declaration of function 'unregister_pstore_blk'; did you mean 'unregister_pstore_zone'? [-Werror=implicit-function-declaration]
     221 |  unregister_pstore_blk(MMC_BLOCK_MAJOR);
         |  ^~~~~~~~~~~~~~~~~~~~~
         |  unregister_pstore_zone
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +2883 drivers/mmc/core/block.c

  2872	
  2873	#if IS_ENABLED(CONFIG_MMC_PSTORE)
  2874	sector_t mmc_blk_get_part(struct mmc_card *card, int part_num, sector_t *size)
  2875	{
  2876		struct mmc_blk_data *md = dev_get_drvdata(&card->dev);
  2877		struct gendisk *disk = md->disk;
  2878		struct disk_part_tbl *part_tbl = disk->part_tbl;
  2879	
  2880		if (part_num < 0 || part_num >= part_tbl->len)
  2881			return 0;
  2882	
> 2883		*size = part_tbl->part[part_num]->nr_sects << SECTOR_SHIFT;
> 2884		return part_tbl->part[part_num]->start_sect;
  2885	}
  2886	#endif
  2887	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (54001 bytes)