lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Jan 2021 18:58:57 +0530 From: Sumit Semwal <sumit.semwal@...aro.org> To: John Stultz <john.stultz@...aro.org> Cc: lkml <linux-kernel@...r.kernel.org>, Liam Mark <lmark@...eaurora.org>, Laura Abbott <labbott@...nel.org>, Brian Starkey <Brian.Starkey@....com>, Hridya Valsaraju <hridya@...gle.com>, Suren Baghdasaryan <surenb@...gle.com>, Sandeep Patil <sspatil@...gle.com>, Daniel Mentz <danielmentz@...gle.com>, Chris Goldsworthy <cgoldswo@...eaurora.org>, Ørjan Eide <orjan.eide@....com>, Robin Murphy <robin.murphy@....com>, Ezequiel Garcia <ezequiel@...labora.com>, Simon Ser <contact@...rsion.fr>, James Jones <jajones@...dia.com>, "open list:DMA BUFFER SHARING FRAMEWORK" <linux-media@...r.kernel.org>, DRI mailing list <dri-devel@...ts.freedesktop.org> Subject: Re: [RESEND][PATCH 1/3] dma-buf: system_heap: Make sure to return an error if we abort Hi John, On Wed, 20 Jan 2021 at 02:15, John Stultz <john.stultz@...aro.org> wrote: > > If we abort from the allocation due to a fatal_signal_pending(), > be sure we report an error so any return code paths don't trip > over the fact that the allocation didn't succeed. Thanks for the patch; LGTM, will push into drm-misc-next. > > Cc: Sumit Semwal <sumit.semwal@...aro.org> > Cc: Liam Mark <lmark@...eaurora.org> > Cc: Laura Abbott <labbott@...nel.org> > Cc: Brian Starkey <Brian.Starkey@....com> > Cc: Hridya Valsaraju <hridya@...gle.com> > Cc: Suren Baghdasaryan <surenb@...gle.com> > Cc: Sandeep Patil <sspatil@...gle.com> > Cc: Daniel Mentz <danielmentz@...gle.com> > Cc: Chris Goldsworthy <cgoldswo@...eaurora.org> > Cc: Ørjan Eide <orjan.eide@....com> > Cc: Robin Murphy <robin.murphy@....com> > Cc: Ezequiel Garcia <ezequiel@...labora.com> > Cc: Simon Ser <contact@...rsion.fr> > Cc: James Jones <jajones@...dia.com> > Cc: linux-media@...r.kernel.org > Cc: dri-devel@...ts.freedesktop.org > Suggested-by: Suren Baghdasaryan <surenb@...gle.com> > Signed-off-by: John Stultz <john.stultz@...aro.org> > --- > drivers/dma-buf/heaps/system_heap.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c > index 17e0e9a68baf..405351aad2a8 100644 > --- a/drivers/dma-buf/heaps/system_heap.c > +++ b/drivers/dma-buf/heaps/system_heap.c > @@ -363,8 +363,10 @@ static int system_heap_allocate(struct dma_heap *heap, > * Avoid trying to allocate memory if the process > * has been killed by SIGKILL > */ > - if (fatal_signal_pending(current)) > + if (fatal_signal_pending(current)) { > + ret = -EINTR; > goto free_buffer; > + } > > page = alloc_largest_available(size_remaining, max_order); > if (!page) > -- > 2.17.1 > Best, Sumit.
Powered by blists - more mailing lists