linux-kernel - Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210121161640.GA1101379@ubuntu-m3-large-x86>
Date:   Thu, 21 Jan 2021 09:16:40 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        clang-built-linux@...glegroups.com, Joe Perches <joe@...ches.com>,
        Ralf Ramsauer <ralf.ramsauer@...-regensburg.de>,
        Pia Eichinger <pia.eichinger@...oth-regensburg.de>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal

On Thu, Jan 21, 2021 at 05:01:15PM +0100, Lukas Bulwahn wrote:
> Commit 6c8ad4427f6e ("kbuild: check the minimum compiler version in
> Kconfig") removed ./scripts/clang-version.sh and moved its content to
> ./scripts/cc-version.sh.
> 
> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
> 
>   warning: no file matches    F:    scripts/clang-version.sh
> 
> The CLANG/LLVM BUILD SUPPORT section in MAINTAINERS intends to track
> changes in ./scripts/clang-version.sh; as the file is removed, track
> changes in ./scripts/cc-version.sh instead now.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
> applies cleanly on next-20210121
> 
> Masahiro-san, please pick this quick fix-up patch.

Masahiro cannot pick this up because the patch to add clang-version.sh
to MAINTAINERS is in mmotm.

I think the better solution is for Andrew to drop the current version of

maintainers-add-a-couple-more-files-to-the-clang-llvm-section.patch

and pick up the second one I sent, which allows us to deal with this:

https://lore.kernel.org/lkml/20210114171629.592007-1-natechancellor@gmail.com/

I am not sure it is right for us to maintain cc-version.sh but I am open
to it if Masahiro agrees.

>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e5d7cf38ec82..aafbea806a82 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4355,8 +4355,8 @@ B:	https://github.com/ClangBuiltLinux/linux/issues
>  C:	irc://chat.freenode.net/clangbuiltlinux
>  F:	Documentation/kbuild/llvm.rst
>  F:	include/linux/compiler-clang.h
> +F:	scripts/cc-version.sh
>  F:	scripts/clang-tools/
> -F:	scripts/clang-version.sh
>  F:	scripts/lld-version.sh
>  K:	\b(?i:clang|llvm)\b
>  
> -- 
> 2.17.1
>