linux-kernel - Re: [PATCH 4/5] watchdog: remove tango driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b57e94ac-85a2-8aa6-5400-400ead370848@roeck-us.net>
Date:   Thu, 21 Jan 2021 08:33:30 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arnd Bergmann <arnd@...nel.org>,
        Måns Rullgård <mans@...sr.com>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        LINUXWATCHDOG <linux-watchdog@...r.kernel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Arnd Bergmann <arnd@...db.de>,
        Marc Gonzalez <marc.w.gonzalez@...e.fr>
Subject: Re: [PATCH 4/5] watchdog: remove tango driver

On 1/21/21 7:18 AM, Arnd Bergmann wrote:
> On Thu, Jan 21, 2021 at 3:01 PM Måns Rullgård <mans@...sr.com> wrote:
>> Arnd Bergmann <arnd@...nel.org> writes:
>>> From: Arnd Bergmann <arnd@...db.de>
>>>
>>> The tango platform is getting removed, so the driver is no
>>> longer needed.
>>>
>>> Cc: Marc Gonzalez <marc.w.gonzalez@...e.fr>
>>> Cc: Mans Rullgard <mans@...sr.com>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>> ---
>>>  drivers/watchdog/Kconfig      |  11 --
>>>  drivers/watchdog/Makefile     |   1 -
>>>  drivers/watchdog/tangox_wdt.c | 209 ----------------------------------
>>>  3 files changed, 221 deletions(-)
>>>  delete mode 100644 drivers/watchdog/tangox_wdt.c
>>
>> The DT binding can go as well.
> 
> Good catch! I thought I had cross-checked all DT compatible strings of the
> removed dts files, bindings and drivers to make sure everything is gone
> at once, but it seems I missed a couple of files including this one.
> 
> Guenter and Wim, let me know if I should resend this patch or all watchdog
> patches, or just remove the binding as part of the platform removal in the
> soc tree.

I'd suggest to just resend this patch, or to send another one on top of it.
It is Wim's call to make, though, since he will apply the patches.

Guenter