lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Jan 2021 10:07:11 -0800 (PST) From: matthew.gerlach@...ux.intel.com To: Pan Bian <bianpan2016@....com> cc: Mark Brown <broonie@...nel.org>, Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>, Wu Hao <hao.wu@...el.com>, linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] spi: altera: Fix memory leak on error path On Wed, 20 Jan 2021, Pan Bian wrote: > Release master that have been previously allocated if the number of > chipselect is invalid. > > Fixes: 8e04187c1bc7 ("spi: altera: add SPI core parameters support via platform data.") > Signed-off-by: Pan Bian <bianpan2016@....com> Acked-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com> > --- > drivers/spi/spi-altera.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c > index cbc4c28c1541..62ea0c9e321b 100644 > --- a/drivers/spi/spi-altera.c > +++ b/drivers/spi/spi-altera.c > @@ -254,7 +254,8 @@ static int altera_spi_probe(struct platform_device *pdev) > dev_err(&pdev->dev, > "Invalid number of chipselect: %hu\n", > pdata->num_chipselect); > - return -EINVAL; > + err = -EINVAL; > + goto exit; > } > > master->num_chipselect = pdata->num_chipselect; > -- > 2.17.1 > >
Powered by blists - more mailing lists