lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Jan 2021 20:03:23 +0100 From: "Rafael J. Wysocki" <rafael@...nel.org> To: Jon Hunter <jonathanh@...dia.com>, Erik Kaneda <erik.kaneda@...el.com>, Nick Desaulniers <ndesaulniers@...gle.com> Cc: Robert Moore <robert.moore@...el.com>, "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>, "Gustavo A . R . Silva" <gustavoars@...nel.org>, clang-built-linux@...glegroups.com, Len Brown <lenb@...nel.org>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-tegra <linux-tegra@...r.kernel.org> Subject: Re: [PATCH] ACPICA: fix -Wfallthrough On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter <jonathanh@...dia.com> wrote: > > > On 11/11/2020 02:11, Nick Desaulniers wrote: > > The "fallthrough" pseudo-keyword was added as a portable way to denote > > intentional fallthrough. This code seemed to be using a mix of > > fallthrough comments that GCC recognizes, and some kind of lint marker. > > I'm guessing that linter hasn't been run in a while from the mixed use > > of the marker vs comments. > > > > Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com> > > > I know this is not the exact version that was merged, I can't find it on > the list, but looks like the version that was merged [0], It would be this patch: https://patchwork.kernel.org/project/linux-acpi/patch/20210115184826.2250-4-erik.kaneda@intel.com/ Nick, Erik? > is causing build errors with older toolchains (GCC v6) ... > > /dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c: In function ‘acpi_ds_exec_begin_control_op’: > /dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: error: ‘ACPI_FALLTHROUGH’ undeclared (first use in this function) > ACPI_FALLTHROUGH; > ^~~~~~~~~~~~~~~~ > /dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: note: each undeclared identifier is reported only once for each function it appears in > /dvs/git/dirty/git-master_l4t-upstream/kernel/scripts/Makefile.build:287: recipe for target 'drivers/acpi/acpica/dscontrol.o' failed > > Cheers > Jon > > [0] https://github.com/acpica/acpica/commit/4b9135f5 > > -- > nvpublic
Powered by blists - more mailing lists