linux-kernel - Re: [PATCH v4] driver core: Fix device link device name collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YAnSGo05jjlQwnor@kroah.com>
Date:   Thu, 21 Jan 2021 20:12:26 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Michael Walle <michael@...le.cc>
Cc:     Saravana Kannan <saravanak@...gle.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>, stable@...r.kernel.org,
        kernel-team@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] driver core: Fix device link device name collision

On Thu, Jan 21, 2021 at 08:01:24PM +0100, Michael Walle wrote:
> Hi,
> 
> Am 2021-01-10 18:54, schrieb Saravana Kannan:
> > The device link device's name was of the form:
> > <supplier-dev-name>--<consumer-dev-name>
> > 
> > This can cause name collision as reported here [1] as device names are
> > not globally unique. Since device names have to be unique within the
> > bus/class, add the bus/class name as a prefix to the device names used
> > to
> > construct the device link device name.
> > 
> > So the devuce link device's name will be of the form:
> > <supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name>:<consumer-dev-name>
> > 
> > [1] -
> > https://lore.kernel.org/lkml/20201229033440.32142-1-michael@walle.cc/
> > 
> > Cc: stable@...r.kernel.org
> > Fixes: 287905e68dd2 ("driver core: Expose device link details in sysfs")
> > Reported-by: Michael Walle <michael@...le.cc>
> > Tested-by: Michael Walle <michael@...le.cc>
> > Signed-off-by: Saravana Kannan <saravanak@...gle.com>
> > ---
> 
> Greg, any news here?

Burried in other patches...

I'll go pick this up now, sorry for the delay.

greg k-h