linux-kernel - Re: [PATCH V2] opp: Prepare for ->set_opp() helper to work without regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58d15e20-8688-99be-b107-4350ff81e90a@gmail.com>
Date:   Fri, 22 Jan 2021 00:02:12 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     linux-pm@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Rafael Wysocki <rjw@...ysocki.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] opp: Prepare for ->set_opp() helper to work without
 regulators

21.01.2021 14:30, Viresh Kumar пишет:
> @@ -1952,9 +1930,16 @@ void dev_pm_opp_put_regulators(struct opp_table *opp_table)
>  	for (i = opp_table->regulator_count - 1; i >= 0; i--)
>  		regulator_put(opp_table->regulators[i]);
>  
> -	_free_set_opp_data(opp_table);
> +	mutex_lock(&opp_table->lock);
> +	if (opp_table->set_opp_data) {
> +		opp_table->set_opp_data->old_opp.supplies = NULL;
> +		opp_table->set_opp_data->new_opp.supplies = NULL;
> +	}
> +	mutex_unlock(&opp_table->lock);
>  
> +	kfree(opp_table->sod_supplies);
>  	kfree(opp_table->regulators);
> +	opp_table->sod_supplies = NULL;
>  	opp_table->regulators = NULL;
>  	opp_table->regulator_count = -1;

The sod_supplies should be unset under the lock.