linux-kernel - Re: [PATCH] mmc: Assign boolean values to a bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210121212057.kxoh7timeczhd4yh@sekiro>
Date:   Thu, 21 Jan 2021 22:20:57 +0100
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
CC:     <ulf.hansson@...aro.org>, <nicolas.ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <linux-mmc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: Assign boolean values to a bool variable

On Wed, Jan 20, 2021 at 03:39:37PM +0800, Jiapeng Zhong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/mmc/host/atmel-mci.c:2436:2-34: WARNING: Assignment
> of 0/1 to bool variable.
> 
> ./drivers/mmc/host/atmel-mci.c:2425:2-20: WARNING: Assignment
> of 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com>

Thanks

> ---
>  drivers/mmc/host/atmel-mci.c | 46 ++++++++++++++++++++++----------------------
>  1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 444bd3a..6324120 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -2401,45 +2401,45 @@ static void atmci_get_cap(struct atmel_mci *host)
>         dev_info(&host->pdev->dev,
>                         "version: 0x%x\n", version);
> 
> -       host->caps.has_dma_conf_reg = 0;
> -       host->caps.has_pdc = 1;
> -       host->caps.has_cfg_reg = 0;
> -       host->caps.has_cstor_reg = 0;
> -       host->caps.has_highspeed = 0;
> -       host->caps.has_rwproof = 0;
> -       host->caps.has_odd_clk_div = 0;
> -       host->caps.has_bad_data_ordering = 1;
> -       host->caps.need_reset_after_xfer = 1;
> -       host->caps.need_blksz_mul_4 = 1;
> -       host->caps.need_notbusy_for_read_ops = 0;
> +       host->caps.has_dma_conf_reg = false;
> +       host->caps.has_pdc = true;
> +       host->caps.has_cfg_reg = false;
> +       host->caps.has_cstor_reg = false;
> +       host->caps.has_highspeed = false;
> +       host->caps.has_rwproof = false;
> +       host->caps.has_odd_clk_div = false;
> +       host->caps.has_bad_data_ordering = true;
> +       host->caps.need_reset_after_xfer = true;
> +       host->caps.need_blksz_mul_4 = true;
> +       host->caps.need_notbusy_for_read_ops = false;
> 
>         /* keep only major version number */
>         switch (version & 0xf00) {
>         case 0x600:
>         case 0x500:
> -               host->caps.has_odd_clk_div = 1;
> +               host->caps.has_odd_clk_div = true;
>                 fallthrough;
>         case 0x400:
>         case 0x300:
> -               host->caps.has_dma_conf_reg = 1;
> -               host->caps.has_pdc = 0;
> -               host->caps.has_cfg_reg = 1;
> -               host->caps.has_cstor_reg = 1;
> -               host->caps.has_highspeed = 1;
> +               host->caps.has_dma_conf_reg = true;
> +               host->caps.has_pdc = false;
> +               host->caps.has_cfg_reg = true;
> +               host->caps.has_cstor_reg = true;
> +               host->caps.has_highspeed = true;
>                 fallthrough;
>         case 0x200:
> -               host->caps.has_rwproof = 1;
> -               host->caps.need_blksz_mul_4 = 0;
> -               host->caps.need_notbusy_for_read_ops = 1;
> +               host->caps.has_rwproof = true;
> +               host->caps.need_blksz_mul_4 = false;
> +               host->caps.need_notbusy_for_read_ops = true;
>                 fallthrough;
>         case 0x100:
> -               host->caps.has_bad_data_ordering = 0;
> -               host->caps.need_reset_after_xfer = 0;
> +               host->caps.has_bad_data_ordering = false;
> +               host->caps.need_reset_after_xfer = false;
>                 fallthrough;
>         case 0x0:
>                 break;
>         default:
> -               host->caps.has_pdc = 0;
> +               host->caps.has_pdc = false;
>                 dev_warn(&host->pdev->dev,
>                                 "Unmanaged mci version, set minimum capabilities\n");
>                 break;
> --
> 1.8.3.1
>