linux-kernel - RE: [PATCH] ACPICA: fix -Wfallthrough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR11MB159916E99EBE052E376FC8D6F0A10@MWHPR11MB1599.namprd11.prod.outlook.com>
Date:   Thu, 21 Jan 2021 22:28:07 +0000
From:   "Kaneda, Erik" <erik.kaneda@...el.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
CC:     Jon Hunter <jonathanh@...dia.com>,
        "Moore, Robert" <robert.moore@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Len Brown <lenb@...nel.org>,
        "ACPI Devel Maling List" <linux-acpi@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>
Subject: RE: [PATCH] ACPICA: fix -Wfallthrough



> -----Original Message-----
> From: Nick Desaulniers <ndesaulniers@...gle.com>
> Sent: Thursday, January 21, 2021 11:08 AM
> To: Rafael J. Wysocki <rafael@...nel.org>; Kaneda, Erik
> <erik.kaneda@...el.com>
> Cc: Jon Hunter <jonathanh@...dia.com>; Moore, Robert
> <robert.moore@...el.com>; Wysocki, Rafael J <rafael.j.wysocki@...el.com>;
> Gustavo A . R . Silva <gustavoars@...nel.org>; clang-built-linux <clang-built-
> linux@...glegroups.com>; Len Brown <lenb@...nel.org>; ACPI Devel
> Maling List <linux-acpi@...r.kernel.org>; open list:ACPI COMPONENT
> ARCHITECTURE (ACPICA) <devel@...ica.org>; Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org>; linux-tegra <linux-tegra@...r.kernel.org>
> Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
> 
> On Thu, Jan 21, 2021 at 11:03 AM Rafael J. Wysocki <rafael@...nel.org>
> wrote:
> >
> > On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter <jonathanh@...dia.com>
> wrote:
> > >
> > >
> > > On 11/11/2020 02:11, Nick Desaulniers wrote:
> > > > The "fallthrough" pseudo-keyword was added as a portable way to
> denote
> > > > intentional fallthrough. This code seemed to be using a mix of
> > > > fallthrough comments that GCC recognizes, and some kind of lint
> marker.
> > > > I'm guessing that linter hasn't been run in a while from the mixed use
> > > > of the marker vs comments.
> > > >
> > > > Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> > >
> > >
> > > I know this is not the exact version that was merged, I can't find it on
> > > the list, but looks like the version that was merged [0],
> >
> > It would be this patch:
> >
> > https://patchwork.kernel.org/project/linux-
> acpi/patch/20210115184826.2250-4-erik.kaneda@...el.com/
> >
> > Nick, Erik?
> 
> oh, shit, looks like a line was dropped.  Here's what I sent upstream:
> https://github.com/acpica/acpica/pull/650/files#diff-
> cccd96e900e01f7224c81508cbddfb1af6fcfbff959d6bfb55123e1b9cad4e38R154
> 3
> Note in the patch Rafael links to that line is missing and there's
> instead an #ifdef that's empty.  Was this line accidentally dropped?

Looks like this line was dropped by ACPICA's Linux-ize scripts. I'll re-add it and send again.

Rafael, do you want me to re-send the series or do you want me to resend the specific commit? I don't mind either way.

Thanks,
Erik
> 
> >
> > > is causing build errors with older toolchains (GCC v6) ...
> > >
> > > /dvs/git/dirty/git-master_l4t-
> upstream/kernel/drivers/acpi/acpica/dscontrol.c: In function
> ‘acpi_ds_exec_begin_control_op’:
> > > /dvs/git/dirty/git-master_l4t-
> upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: error:
> ‘ACPI_FALLTHROUGH’ undeclared (first use in this function)
> > >    ACPI_FALLTHROUGH;
> > >    ^~~~~~~~~~~~~~~~
> > > /dvs/git/dirty/git-master_l4t-
> upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: note: each
> undeclared identifier is reported only once for each function it appears in
> > > /dvs/git/dirty/git-master_l4t-
> upstream/kernel/scripts/Makefile.build:287: recipe for target
> 'drivers/acpi/acpica/dscontrol.o' failed
> > >
> > > Cheers
> > > Jon
> > >
> > > [0] https://github.com/acpica/acpica/commit/4b9135f5
> > >
> > > --
> > > nvpublic
> 
> 
> 
> --
> Thanks,
> ~Nick Desaulniers