linux-kernel - Re: [PATCH v1 1/2] watchdog: pcwd: drop always-false if from remove callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210121230800.GA37574@roeck-us.net>
Date:   Thu, 21 Jan 2021 15:08:00 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] watchdog: pcwd: drop always-false if from remove
 callback

On Thu, Jan 21, 2021 at 09:48:11PM +0100, Uwe Kleine-König wrote:
> If pcwd_isa_probe() succeeded pcwd_private.io_addr cannot be NULL. (And
> if pcwd_isa_probe() failed, pcwd_isa_remove() isn't called.)
> 
> Signed-off-by: Uwe Kleine-König <uwe@...ine-koenig.org>

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/pcwd.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/watchdog/pcwd.c b/drivers/watchdog/pcwd.c
> index e86fa7f8351d..b95cd38f3ceb 100644
> --- a/drivers/watchdog/pcwd.c
> +++ b/drivers/watchdog/pcwd.c
> @@ -956,9 +956,6 @@ static int pcwd_isa_remove(struct device *dev, unsigned int id)
>  	if (debug >= DEBUG)
>  		pr_debug("pcwd_isa_remove id=%d\n", id);
>  
> -	if (!pcwd_private.io_addr)
> -		return 1;
> -
>  	/*  Disable the board  */
>  	if (!nowayout)
>  		pcwd_stop();
> -- 
> 2.29.2
>