linux-kernel - Re: [PATCH 08/20] clk: socfpga: clk-pll-a10: Remove set but unused variable 'rc'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77dcbc1a-d0c6-aa35-57f4-a3bc66d81a87@kernel.org>
Date:   Wed, 20 Jan 2021 22:11:59 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org
Subject: Re: [PATCH 08/20] clk: socfpga: clk-pll-a10: Remove set but unused
 variable 'rc'



On 1/20/21 3:30 AM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/clk/socfpga/clk-pll-a10.c: In function ‘__socfpga_pll_init’:
>   drivers/clk/socfpga/clk-pll-a10.c:76:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
> 
> Cc: Dinh Nguyen <dinguyen@...nel.org>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: linux-clk@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>   drivers/clk/socfpga/clk-pll-a10.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/socfpga/clk-pll-a10.c b/drivers/clk/socfpga/clk-pll-a10.c
> index db54f7d806a09..3338f054fe98c 100644
> --- a/drivers/clk/socfpga/clk-pll-a10.c
> +++ b/drivers/clk/socfpga/clk-pll-a10.c
> @@ -73,7 +73,6 @@ static struct clk * __init __socfpga_pll_init(struct device_node *node,
>   	const char *parent_name[SOCFGPA_MAX_PARENTS];
>   	struct clk_init_data init;
>   	struct device_node *clkmgr_np;
> -	int rc;
>   	int i = 0;
>   
>   	of_property_read_u32(node, "reg", &reg);
> @@ -108,7 +107,7 @@ static struct clk * __init __socfpga_pll_init(struct device_node *node,
>   		kfree(pll_clk);
>   		return NULL;
>   	}
> -	rc = of_clk_add_provider(node, of_clk_src_simple_get, clk);
> +	of_clk_add_provider(node, of_clk_src_simple_get, clk);
>   	return clk;
>   }
>   
> 

Acked-by: Dinh Nguyen <dinguyen@...nel.org>