lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Jan 2021 21:35:22 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Alex Elder <elder@...aro.org> Cc: davem@...emloft.net, elder@...nel.org, evgreen@...omium.org, bjorn.andersson@...aro.org, cpratapa@...eaurora.org, subashab@...eaurora.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next 3/5] net: ipa: have gsi_channel_update() return a value On Wed, 20 Jan 2021 16:03:59 -0600 Alex Elder wrote: > Have gsi_channel_update() return the first transaction in the > updated completed transaction list, or NULL if no new transactions > have been added. > > Signed-off-by: Alex Elder <elder@...aro.org> > @@ -1452,7 +1452,7 @@ void gsi_channel_doorbell(struct gsi_channel *channel) > } > > /* Consult hardware, move any newly completed transactions to completed list */ > -static void gsi_channel_update(struct gsi_channel *channel) > +struct gsi_trans *gsi_channel_update(struct gsi_channel *channel) Why did it lose the 'static'? drivers/net/ipa/gsi.c:1455:19: warning: no previous prototype for ‘gsi_channel_update’ [-Wmissing-prototypes] 1455 | struct gsi_trans *gsi_channel_update(struct gsi_channel *channel) | ^~~~~~~~~~~~~~~~~~
Powered by blists - more mailing lists