linux-kernel - Re: [PATCH] mm/vmalloc: Separate put pages and flush VM flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210121070835.GA23327@lst.de>
Date:   Thu, 21 Jan 2021 08:08:35 +0100
From:   Christoph Hellwig <hch@....de>
To:     Rick Edgecombe <rick.p.edgecombe@...el.com>
Cc:     akpm@...ux-foundation.org, hch@....de, dja@...ens.net,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmalloc: Separate put pages and flush VM flags

On Wed, Jan 20, 2021 at 05:41:18PM -0800, Rick Edgecombe wrote:
> When VM_MAP_PUT_PAGES was added, it was defined with the same value as
> VM_FLUSH_RESET_PERMS. This doesn't seem like it will cause any big
> functional problems other than some excess flushing for VM_MAP_PUT_PAGES
> allocations.
> 
> Redefine VM_MAP_PUT_PAGES to have its own value. Also, move the comment
> and remove whitespace for VM_KASAN such that the flags lower down are less
> likely to be missed in the future.
> 
> Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap")
> Signed-off-by: Rick Edgecombe <rick.p.edgecombe@...el.com>

Ooops.  Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>