linux-kernel - Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210121073030.GA423216@kuha.fi.intel.com>
Date:   Thu, 21 Jan 2021 09:30:30 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Hans de Goede <hdegoede@...hat.com>, Kyle Tso <kyletso@...gle.com>,
        linux@...ck-us.net, badhri@...gle.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error

On Wed, Jan 20, 2021 at 06:17:35PM +0100, Greg KH wrote:
> On Wed, Jan 20, 2021 at 02:45:02PM +0100, Hans de Goede wrote:
> > Hi,
> > 
> > On 1/14/21 3:50 PM, Kyle Tso wrote:
> > > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com
> > > 
> > > "usb: typec: tcpm: AMS and Collision Avoidance"
> > >  - removed the signed-off
> > >  - modified the coding style suggested from Heikki
> > >  - added FR_SWAP AMS handling
> > > 
> > > "usb: typec: tcpm: Protocol Error handling"
> > >  - removed the signed-off
> > >  - modified the coding style suggested from Heikki
> > >  - modified more coding style problems (line wrapping limit)
> > > 
> > > "usb: typec: tcpm: Respond Wait if VDM state machine is running"
> > >  - no change
> > 
> > I've finally gotten around to testing this. I'm happy to
> > report that the power-role swapping regression seen in one
> > of the older versions of this patch-set is gone.
> > 
> > So the entire series is:
> > Tested-by: Hans de Goede <hdegoede@...hat.com>
> 
> Thanks for testing and the review.
> 
> Heikki, any thoughts?

Looks good to me.

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

-- 
heikki