linux-kernel - RE: [PATCH] rtsx: pci: fix device aspm state bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b54d74ea7324bf4b829772cdbc0a742@realtek.com>
Date:   Thu, 21 Jan 2021 07:59:39 +0000
From:   吳昊澄 Ricky <ricky_wu@...ltek.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "ricky_wu@...ltek.corp-partner.google.com" 
        <ricky_wu@...ltek.corp-partner.google.com>,
        "sashal@...nel.org" <sashal@...nel.org>,
        "levinale@...gle.com" <levinale@...gle.com>,
        "keitasuzuki.park@...ab.ics.keio.ac.jp" 
        <keitasuzuki.park@...ab.ics.keio.ac.jp>,
        "kdlnx@...h.eu" <kdlnx@...h.eu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yueherngl@...omium.org" <yueherngl@...omium.org>
Subject: RE: [PATCH] rtsx: pci: fix device aspm state bug

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Thursday, January 21, 2021 3:46 PM
> To: 吳昊澄 Ricky <ricky_wu@...ltek.com>
> Cc: arnd@...db.de; ricky_wu@...ltek.corp-partner.google.com;
> sashal@...nel.org; levinale@...gle.com; keitasuzuki.park@...ab.ics.keio.ac.jp;
> kdlnx@...h.eu; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] rtsx: pci: fix device aspm state bug
> 
> On Thu, Jan 21, 2021 at 03:28:58PM +0800, ricky_wu@...ltek.com wrote:
> > From: Ricky Wu <ricky_wu@...ltek.corp-partner.google.com>
> >
> > changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure
> > pcr->aspm_enabled to sync with aspm state
> 
> Can you make this a bit more descriptive?
> 
Changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure
pcr->aspm_enabled to sync with aspm state.
rtsx_pci_disable_aspm() this function disable aspm by setting config space directly
did not change value of pcr->aspm_enabled so changed to use rtsx_disable_aspm().
Give initial value to pcr->aspm_enabled by reading config space setting at init_hw(). 

> 
> >
> > BUG=b:175338107
> > TEST=chromeos-kernel-5_4
> 
> What are these lines for?
> 
> >
> > Signed-off-by: Ricky Wu <ricky_wu@...ltek.corp-partner.google.com>
> 
> This email does not match your From: address :(
> 
> > Change-Id: I4b146dcdaaf2f2a965381c32780b0b110d751258
> 
> Please use checkpatch.pl before sending patches to us :(
> 
> And why did you send this twice?
> 
> thanks,
> 
> greg k-h
> 
> ------Please consider the environment before printing this e-mail.