lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Jan 2021 09:39:19 +0100 From: Daniel Vetter <daniel@...ll.ch> To: Christoph Hellwig <hch@....de> Cc: Frederic Barrat <fbarrat@...ux.ibm.com>, Andrew Donnellan <ajd@...ux.ibm.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...ux.ie>, Jessica Yu <jeyu@...nel.org>, Josh Poimboeuf <jpoimboe@...hat.com>, Jiri Kosina <jikos@...nel.org>, Miroslav Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>, Joe Lawrence <joe.lawrence@...hat.com>, Masahiro Yamada <masahiroy@...nel.org>, Michal Marek <michal.lkml@...kovi.net>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, dri-devel <dri-devel@...ts.freedesktop.org>, live-patching@...r.kernel.org, linux-kbuild <linux-kbuild@...r.kernel.org> Subject: Re: [PATCH 08/13] drm: remove drm_fb_helper_modinit On Thu, Jan 21, 2021 at 9:28 AM Christoph Hellwig <hch@....de> wrote: > > On Thu, Jan 21, 2021 at 09:25:40AM +0100, Daniel Vetter wrote: > > On Thu, Jan 21, 2021 at 8:55 AM Christoph Hellwig <hch@....de> wrote: > > > > > > drm_fb_helper_modinit has a lot of boilerplate for what is not very > > > simple functionality. Just open code it in the only caller using > > > IS_ENABLED and IS_MODULE. > > > > > > Signed-off-by: Christoph Hellwig <hch@....de> > > > > I didn't spot any dependencies with your series, should I just merge > > this through drm trees? Or do you want an ack? > > I'd prefer an ACK - module_loaded() is only introduced earlier in this > series. I was looking for that but didn't find the hunk touching drm somehow ... Acked-by: Daniel Vetter <daniel.vetter@...ll.ch> Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Powered by blists - more mailing lists