linux-kernel - Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b54335cd-2009-3542-a175-6118c294fd74@lineo.co.jp>
Date:   Thu, 21 Jan 2021 18:14:40 +0900
From:   Naoki Hayama <naoki.hayama@...eo.co.jp>
To:     Luca Ceresoli <luca@...aceresoli.net>,
        Chunyou Tang <tangchunyou@....com>,
        Joe Perches <joe@...ches.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>, akpm@...ux-foundation.org,
        colin.king@...onical.com, xndchn@...il.com, j.neuschaefer@....net,
        ebiggers@...gle.com, sjpark@...zon.de,
        linux-kernel@...r.kernel.org, zhangwen@...ong.com,
        tangchunyou@...ong.com
Subject: Re: [PATCH] scripts/spelling.txt: increase error-prone spell checking

Dear Chunyou,

On 2021/01/21 17:41, Luca Ceresoli wrote:
> Hi,
> 
> On 21/01/21 04:21, Chunyou Tang wrote:
>> On Wed, 20 Jan 2021 19:09:05 -0800
>> Joe Perches <joe@...ches.com> wrote:
>>
>>> On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
>>>> On 1/20/21 6:07 PM, ChunyouTang wrote:  
>>>>> From: tangchunyou <tangchunyou@...ong.com>
>>>>>
>>>>> Increase direcly,maping,manger spelling error check  
>>>>
>>>> Hi,
>>>> I don't see all of those in the patch below.
>>>> What happened?  
>>>
>>> I think mostly it's just a poor commit message as
>>> direcly and manger are already in spelling.txt
>>>
>>>>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt  
>>> []
>>>>> @@ -875,6 +875,7 @@ manger||manager
>>>>>  manoeuvering||maneuvering
>>>>>  manufaucturing||manufacturing
>>>>>  mappping||mapping
>>>>> +maping||mapping
>>>>>  matchs||matches
>>>>>  mathimatical||mathematical
>>>>>  mathimatic||mathematic  
>>>
>>
>> yes,you are right,the commit message is bad,I change the commit message
>>
>> and resend it.
> 
> While doing that, also improve the subject (1st line of commit message)
> by mentioning the typo you are adding. For example, as in previous commits:
> 
>   scripts/spelling.txt: add "maping" typo
> 
> It's more informative and even shorter.
> 
> Thanks
> 

Rules in scripts/spelling.txt are sorted
alphabetically by leftside words. It would
be better that you insert "maping||mapping"
rule between:

"manufaucturing||manufacturing"
and
"mappping||mapping" .


Best regards,

Naoki Hayama