linux-kernel - Re: [PATCH v2] can: mcp251xfd: replace sizeof(u32) with val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210121094422.h5tjjyhsn7gvhlrm@hardanger.blackshift.org>
Date:   Thu, 21 Jan 2021 10:44:22 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Su <suyanjun218@...il.com>
Cc:     manivannan.sadhasivam@...aro.org, thomas.kopp@...rochip.com,
        wg@...ndegger.com, davem@...emloft.net, kuba@...nel.org,
        lgirdwood@...il.com, broonie@...nel.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] can: mcp251xfd: replace sizeof(u32) with val_bytes in
 regmap

On Thu, Jan 21, 2021 at 05:33:40PM +0800, Su wrote:
> The sizeof(u32) is hardcoded. IMO it's better to use the config value in
> regmap.

I got why you want to change this. Please update the patch description, comment
on the increase of the object size and address the other issues I pointed out.
I think it makes no sense to have the function mcp251xfd_get_val_bytes() as you
have to use several regmaps anyways.

> > > No functional effect.
> > Not quite:
> > 
> > scripts/bloat-o-meter shows:
> > 
> > add/remove: 0/0 grow/shrink: 3/0 up/down: 104/0 (104)
> > Function                                     old     new   delta
> > mcp251xfd_handle_tefif                       980    1028     +48
> > mcp251xfd_irq                               3716    3756     +40
> > mcp251xfd_handle_rxif_ring                   964     980     +16
> > Total: Before=20832, After=20936, chg +0.50%

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)