linux-kernel - Re: [PATCH] arm64: dts: zynqmp: Add address-cells property to interrupt controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Jan 2021 11:17:34 +0100
From:   Michal Simek <monstr@...str.eu>
To:     LKML <linux-kernel@...r.kernel.org>,
        Michal Simek <monstr@...str.eu>, git <git@...inx.com>
Cc:     Andre Przywara <andre.przywara@....com>,
        Kalyani Akula <kalyani.akula@...inx.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Manish Narani <manish.narani@...inx.com>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Rob Herring <robh+dt@...nel.org>,
        DTML <devicetree@...r.kernel.org>,
        linux-arm <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: zynqmp: Add address-cells property to
 interrupt controllers

st 2. 12. 2020 v 15:14 odesílatel Michal Simek <michal.simek@...inx.com> napsal:
>
> The commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version
> v1.6.0-11-g9d7888cbf19c") updated dtc version which also contained DTC
> commit
> "81e0919a3e21 checks: Add interrupt provider test"
> where reasons for this checking are mentioned as
> "A missing #address-cells property is less critical, but creates
> ambiguities when used in interrupt-map properties, so warn about this as
> well now."
>
> That's why add address-cells property to gic and gpio nodes to get rid of
> this warning.
>
> CC: Andre Przywara <andre.przywara@....com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>
> I was grepping DTSes in the kernel and most of them list it as 0.
> In gicv3 case where its node is added it needs to be filled property that's
> why also non 0 values are there.
> Definitely please let me know if 0 is not the right value here.
>
> Based on https://lore.kernel.org/r/cover.1606917949.git.michal.simek@xilinx.com/
>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 14a2e69cf98b..5b2051ac6965 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -368,6 +368,7 @@ fpd_dma_chan8: dma@...70000 {
>
>                 gic: interrupt-controller@...10000 {
>                         compatible = "arm,gic-400";
> +                       #address-cells = <0>;
>                         #interrupt-cells = <3>;
>                         reg = <0x0 0xf9010000 0x0 0x10000>,
>                               <0x0 0xf9020000 0x0 0x20000>,
> @@ -574,6 +575,7 @@ gem3: ethernet@...e0000 {
>                 gpio: gpio@...a0000 {
>                         compatible = "xlnx,zynqmp-gpio-1.0";
>                         status = "disabled";
> +                       #address-cells = <0>;
>                         #gpio-cells = <0x2>;
>                         gpio-controller;
>                         interrupt-parent = <&gic>;
> --
> 2.29.2
>

Applied.
M


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs